Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Test_runImportCmd() #133

Merged
merged 1 commit into from
Apr 19, 2021
Merged

Conversation

jinsan-line
Copy link
Contributor

@jinsan-line jinsan-line commented Apr 19, 2021

Description

  • fix Test_runImportCmd().
  • It's success only first time but failed after second execution.
  • W/ CI environment, it's not issue because it's executed always w/ fresh docker container.

The reason why it's failed.

  • If we set FlagKeyringBackend, the keyring is overwritten by cmd.
  • If keyring is overwritten, the keyring uses home/keyring... dir but not a temp dir.
  • It fails to delete a test key because the keyring for test is overwritten.
  • So, after second execution, it fails due there is already same key.

Reference

https://github.com/line/lbm-sdk/blob/c508498905f249c39ce36ca3c45949546dcafb63/client/cmd.go#L119-L130


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@jinsan-line jinsan-line added this to the Initail ebony milestone Apr 19, 2021
@jinsan-line jinsan-line self-assigned this Apr 19, 2021
@jinsan-line jinsan-line merged commit 18fd562 into v2/develop Apr 19, 2021
@jinsan-line jinsan-line deleted the jinsan/v2/fix-test-run-import-cmd branch April 19, 2021 10:43
brew0722 pushed a commit that referenced this pull request Apr 26, 2021
…bsocket-extensions-0.1.4

Bump websocket-extensions from 0.1.3 to 0.1.4 in /docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants